Conversation
srueg
force-pushed
the
lieutenant-fact
branch
2 times, most recently
from
1089d21 to
d62c714
Compare
simu
requested changes
May 14, 2020
Member
simu
left a comment
simu
left a comment
There was a problem hiding this comment.
Change makes sense overall. It's a bit ugly that we have to re-extract a Lieutenant fact from the list of configured classes in local mode, but I guess we don't set the Lieutenant instance anywhere in the target.yml parameters.
Contributor
Author
|
Yes, I was thinking the same. I guess once we implement #93 we can rework the local mode as well. |
corvus-ch
reviewed
May 14, 2020
corvus-ch
approved these changes
May 14, 2020
Signed-off-by: Simon Rüegg <simon@rueggs.ch>
If the fact `lieutenant-instance` is set, add it to the classes. Relates to projectsyn/lieutenant-api#52 Signed-off-by: Simon Rüegg <simon@rueggs.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to projectsyn/lieutenant-api#52